VPP: Fix VLAN SVI LCP address sync and OSPF MTU - #3730
Conversation
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
It works ;)) Thank you!
Will run complete integration tests for BIRD and VPP just to be on the safe side, but I don't expect any surprises.
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Ouch, we have a merge conflict, and I don't know enough about VPP to confidently resolve it. Please fix it, and I'll merge the PR.
ipspace
added
the
needs changes
BVI addresses were set before lcp create, so lcp-sync never mirrored them into the dataplane netns and BIRD/FRR had no SVI IPs. Also set Linux TAP MTU on SVIs (BVI packet MTU is not changeable) so OSPF DBD MTU matches peers, and run post-VPP setup once inside the netns. Co-authored-by: Cursor <cursoragent@cursor.com>
236c20e to
001686c
Compare
I restructured the startup script to run the whole thing inside the netns instead of every separate command - it looks more complicated than it is, and should be a one-time thing. Try now |
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
BIRD control plane works as expected ;)), did not test FRR. Great job, thanks a million.
2 participants
BVI addresses were set before lcp create, so lcp-sync never mirrored them into the dataplane netns and BIRD/FRR had no SVI IPs. Also set Linux TAP MTU on SVIs (BVI packet MTU is not changeable) so OSPF DBD MTU matches peers, and run post-VPP setup once inside the netns.
Fixes #3724
Tested:
./device-module-test -d vpp -p clab initialandnetlab up ospf/ospfv2/06-vlan-mtu.yml -d vpp -p clab